Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Duration Plugin parsing milliseconds bug #1042

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Sep 11, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #1042 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1042   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          171       171           
  Lines         1488      1513   +25     
  Branches       315       323    +8     
=========================================
+ Hits          1488      1513   +25     
Impacted Files Coverage Δ
src/plugin/duration/index.js 100.00% <ø> (ø)
src/plugin/timezone/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1533a2c...2e67bf2. Read the comment docs.

@iamkun iamkun merged commit fe2301b into dev Sep 11, 2020
@csvwolf
Copy link
Contributor

csvwolf commented Sep 11, 2020

: ) Love and peace

@iamkun
Copy link
Owner Author

iamkun commented Sep 11, 2020

: ) Love and peace

🎉

iamkun pushed a commit that referenced this pull request Sep 17, 2020
## [1.8.36](v1.8.35...v1.8.36) (2020-09-17)

### Bug Fixes

* Add Amharic (am) locale ([#1046](#1046)) ([cdc49a1](cdc49a1))
* Export Duration type in duration plugin ([#1043](#1043)) ([0f20c3a](0f20c3a))
* Fix duration plugin parsing milliseconds bug ([#1042](#1042)) ([fe2301b](fe2301b))
* Timezone plugin set default timezone ([#1033](#1033)) ([0c2050a](0c2050a))
* Timezone plugin should have the same behavior in latest ICU version ([#1032](#1032)) ([de31592](de31592))
* Update Finnish (fi) locale ([#963](#963)) ([cf8b6a0](cf8b6a0))
* Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](#1045)) ([638fd39](638fd39))
@iamkun
Copy link
Owner Author

iamkun commented Sep 17, 2020

🎉 This PR is included in version 1.8.36 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun deleted the fix/duration-plugin branch September 28, 2020 02:27
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17)

### Bug Fixes

* Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([cdc49a1](iamkun/dayjs@cdc49a1))
* Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([0f20c3a](iamkun/dayjs@0f20c3a))
* Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([fe2301b](iamkun/dayjs@fe2301b))
* Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([0c2050a](iamkun/dayjs@0c2050a))
* Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([de31592](iamkun/dayjs@de31592))
* Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([cf8b6a0](iamkun/dayjs@cf8b6a0))
* Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([638fd39](iamkun/dayjs@638fd39))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17)

### Bug Fixes

* Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([cdc49a1](iamkun/dayjs@cdc49a1))
* Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([0f20c3a](iamkun/dayjs@0f20c3a))
* Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([fe2301b](iamkun/dayjs@fe2301b))
* Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([0c2050a](iamkun/dayjs@0c2050a))
* Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([de31592](iamkun/dayjs@de31592))
* Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([cf8b6a0](iamkun/dayjs@cf8b6a0))
* Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([638fd39](iamkun/dayjs@638fd39))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17)

### Bug Fixes

* Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([7740c39](iamkun/dayjs@7740c39))
* Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([b0c49de](iamkun/dayjs@b0c49de))
* Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([48ad2c4](iamkun/dayjs@48ad2c4))
* Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([db84b1e](iamkun/dayjs@db84b1e))
* Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([9e47a7f](iamkun/dayjs@9e47a7f))
* Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([4b798d0](iamkun/dayjs@4b798d0))
* Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([2c09de5](iamkun/dayjs@2c09de5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants