Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update timezone plugin to support getting offset name e.g. EST #1069

Merged
merged 2 commits into from
Sep 25, 2020
Merged

fix: update timezone plugin to support getting offset name e.g. EST #1069

merged 2 commits into from
Sep 25, 2020

Conversation

zazzaz
Copy link
Contributor

@zazzaz zazzaz commented Sep 23, 2020

No description provided.

@zazzaz zazzaz mentioned this pull request Sep 23, 2020
Closed
@codecov
Copy link

codecov bot commented Sep 23, 2020 •
edited
Loading

Codecov Report

Merging #1069 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1069   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1524      1534   +10     
  Branches       323       324    +1     
=========================================
+ Hits          1524      1534   +10
Impacted Files Coverage Δ
src/plugin/advancedFormat/index.js 100.00% <100.00%> (ø)
src/plugin/duration/index.js 100.00% <100.00%> (ø)
src/plugin/timezone/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d73543...ced33f4. Read the comment docs.

akoskm
akoskm reviewed Sep 23, 2020
View reviewed changes
test/plugin/timezone.test.js Outdated
expect(d).toBe(m)
expect(d).toBe('EST')
})
it('short', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say 'long'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@iamkun iamkun merged commit cbb755e into iamkun:dev Sep 25, 2020
iamkun pushed a commit that referenced this pull request Sep 28, 2020
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
de3e3fb 
# [1.9.0](v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](#1057)) ([c0f0886](c0f0886))
* fix DST bug in utc plugin ([#1053](#1053)) ([3d73543](3d73543))
* Fix optional type for timezone plugin ([#1081](#1081)) ([a6ebcf2](a6ebcf2)), closes [#1079](#1079)
* Fix timezone plugin conversion bug ([#1073](#1073)) ([16816a3](16816a3))
* update duration plugin type file ([#1065](#1065)) ([94af9af](94af9af))
* update timezone plugin to support getting offset name e.g. EST ([#1069](#1069)) ([cbb755e](cbb755e))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](#1080)) ([5ce4e0d](5ce4e0d))

### Features

* Correct casing for en-sg locale name ([#1048](#1048)) ([2edaddc](2edaddc))
@iamkun
Copy link
Owner

iamkun commented Sep 28, 2020

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mrkrlli mrkrlli mentioned this pull request Oct 21, 2020
Closed
PDXfoster added a commit to PDXfoster/dayjs-website that referenced this pull request Sep 7, 2021
@PDXfoster
add documentation for z formatting
adb8ef5 
I didn't see anything in the readme about contributions, but I'm hoping this is acceptable - I'm not 100% sure it fits with "parsing" - I haven't tried that side of the feature, but it does work for formatting per: iamkun/dayjs#1069 

Thanks for all your work on this package!
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.0 [skip ci]
efdb5fb 
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([c0f0886](iamkun/dayjs@c0f0886))
* fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([3d73543](iamkun/dayjs@3d73543))
* Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([a6ebcf2](iamkun/dayjs@a6ebcf2)), closes [#1079](iamkun/dayjs#1079)
* Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([16816a3](iamkun/dayjs@16816a3))
* update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([94af9af](iamkun/dayjs@94af9af))
* update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([cbb755e](iamkun/dayjs@cbb755e))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([5ce4e0d](iamkun/dayjs@5ce4e0d))

### Features

* Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([2edaddc](iamkun/dayjs@2edaddc))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.0 [skip ci]
701fee4 
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([c0f0886](iamkun/dayjs@c0f0886))
* fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([3d73543](iamkun/dayjs@3d73543))
* Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([a6ebcf2](iamkun/dayjs@a6ebcf2)), closes [#1079](iamkun/dayjs#1079)
* Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([16816a3](iamkun/dayjs@16816a3))
* update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([94af9af](iamkun/dayjs@94af9af))
* update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([cbb755e](iamkun/dayjs@cbb755e))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([5ce4e0d](iamkun/dayjs@5ce4e0d))

### Features

* Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([2edaddc](iamkun/dayjs@2edaddc))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.9.0 [skip ci]
bb0d9e2 
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([1be7ea3](iamkun/dayjs@1be7ea3))
* fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([37380af](iamkun/dayjs@37380af))
* Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([2b6813f](iamkun/dayjs@2b6813f)), closes [#1079](iamkun/dayjs#1079)
* Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([0dcf358](iamkun/dayjs@0dcf358))
* update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([ad83629](iamkun/dayjs@ad83629))
* update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([8742f04](iamkun/dayjs@8742f04))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([a8bb502](iamkun/dayjs@a8bb502))

### Features

* Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([b6bb9bb](iamkun/dayjs@b6bb9bb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoskm akoskm akoskm left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zazzaz @iamkun @akoskm