[bug] Fix startOf with active timezone/UTC
#2481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
The method has been added in https://github.com/iamkun/dayjs/pull/1229/files |
I did double check the tests (and ran some more on the side myself) and as far as i can see the problem does not appear anymore with or without the overloaded As long as I did not have overlooked something this should fix the issue. |
|
@iamkun is this on your radar? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overloaded
startOffunction did call thetzfunction again which resulted in a duplicate subtraction of the timezone offset.Simply removing it did yield the correct values in all cases I did encounter.
I did also add some tests so that the coverage stays up! 👍🏼
Fixes #2373 and #2303