fixed formatting issue #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #536 +/- ##
===================================
Coverage 100% 100%
===================================
Files 70 70
Lines 663 663
Branches 114 114
===================================
Hits 663 663
Continue to review full report at Codecov.
|
iamkun
reviewed
Mar 17, 2019
| @@ -9,7 +9,7 @@ const matchUpperCaseAMPM = /[AP]M/ | |||
| const matchLowerCaseAMPM = /[ap]m/ | |||
| const matchSigned = /[+-]?\d+/ // -inf - inf | |||
| const matchOffset = /[+-]\d\d:?\d\d/ // +00:00 -00:00 +0000 or -0000 | |||
| const matchWord = /\d*[^\s\d]+/ // Word | |||
| const matchWord = /\d*[^\s\d-:/.()]+/ // Word | |||
There was a problem hiding this comment.
Good fix.
Do we need to list more possible divider (such as \ / _ etc, I'm not sure)?
There was a problem hiding this comment.
Yes, we can include if we are considering them as the format separator, in this case, we also need to modify
.Should I include these dividers("_" and "\")?
There was a problem hiding this comment.
Not sure, to be honest.
Maybe we could add these later but not this time. 😬
There was a problem hiding this comment.
Thanks @iamkun. :)
iamkun
pushed a commit
that referenced
this pull request
Mar 21, 2019
## [1.8.11](v1.8.10...v1.8.11) (2019-03-21) ### Bug Fixes * Add .add('quarter') .startOf('quarter') through plugin quarterOfYear ([dde39e9](dde39e9)), closes [#537](#537) [#531](#531) * Add locale support for Azerbaijani language (az) ([#535](#535)) ([eeb20fa](eeb20fa)) * Correct typescript definition `add` ([22a249c](22a249c)), closes [#531](#531) * Fix CustomParseFormat plugin formatting bug ([#536](#536)) ([8578546](8578546)), closes [#533](#533) * Update pt locale ([#538](#538)) ([1ac9e1e](1ac9e1e))
|
🎉 This PR is included in version 1.8.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.11](iamkun/dayjs@v1.8.10...v1.8.11) (2019-03-21) ### Bug Fixes * Add .add('quarter') .startOf('quarter') through plugin quarterOfYear ([dde39e9](iamkun/dayjs@dde39e9)), closes [#537](iamkun/dayjs#537) [#531](iamkun/dayjs#531) * Add locale support for Azerbaijani language (az) ([#535](iamkun/dayjs#535)) ([eeb20fa](iamkun/dayjs@eeb20fa)) * Correct typescript definition `add` ([22a249c](iamkun/dayjs@22a249c)), closes [#531](iamkun/dayjs#531) * Fix CustomParseFormat plugin formatting bug ([#536](iamkun/dayjs#536)) ([8578546](iamkun/dayjs@8578546)), closes [#533](iamkun/dayjs#533) * Update pt locale ([#538](iamkun/dayjs#538)) ([1ac9e1e](iamkun/dayjs@1ac9e1e))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.11](iamkun/dayjs@v1.8.10...v1.8.11) (2019-03-21) ### Bug Fixes * Add .add('quarter') .startOf('quarter') through plugin quarterOfYear ([dde39e9](iamkun/dayjs@dde39e9)), closes [#537](iamkun/dayjs#537) [#531](iamkun/dayjs#531) * Add locale support for Azerbaijani language (az) ([#535](iamkun/dayjs#535)) ([eeb20fa](iamkun/dayjs@eeb20fa)) * Correct typescript definition `add` ([22a249c](iamkun/dayjs@22a249c)), closes [#531](iamkun/dayjs#531) * Fix CustomParseFormat plugin formatting bug ([#536](iamkun/dayjs#536)) ([8578546](iamkun/dayjs@8578546)), closes [#533](iamkun/dayjs#533) * Update pt locale ([#538](iamkun/dayjs#538)) ([1ac9e1e](iamkun/dayjs@1ac9e1e))
allmoviestvshowslistsfilmography28
added a commit
to allmoviestvshowslistsfilmography28/dayjs
that referenced
this pull request
Sep 12, 2024
## [1.8.11](iamkun/dayjs@v1.8.10...v1.8.11) (2019-03-21) ### Bug Fixes * Add .add('quarter') .startOf('quarter') through plugin quarterOfYear ([764b0ce](iamkun/dayjs@764b0ce)), closes [#537](iamkun/dayjs#537) [#531](iamkun/dayjs#531) * Add locale support for Azerbaijani language (az) ([#535](iamkun/dayjs#535)) ([078556a](iamkun/dayjs@078556a)) * Correct typescript definition `add` ([d03d7e9](iamkun/dayjs@d03d7e9)), closes [#531](iamkun/dayjs#531) * Fix CustomParseFormat plugin formatting bug ([#536](iamkun/dayjs#536)) ([dcb2b9b](iamkun/dayjs@dcb2b9b)), closes [#533](iamkun/dayjs#533) * Update pt locale ([#538](iamkun/dayjs#538)) ([7c188fa](iamkun/dayjs@7c188fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #533
Got Invalid Date when use customParseFormat parse.