TypeScript Definition: Make isSame accept quarter as unit with quarterOfYear imported
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `isSame` accept `quarter` as the unit
Codecov Report
@@ Coverage Diff @@
## dev #588 +/- ##
===================================
Coverage 100% 100%
===================================
Files 154 154
Lines 983 983
Branches 140 140
===================================
Hits 983 983Continue to review full report at Codecov.
|
|
Thanks. You are right. And we should update isAfter isBefore as well. Plus, add a blank line, please. |
|
Fixed. |
iamkun
reviewed
May 6, 2019
types/plugin/quarterOfYear.d.ts
Outdated
| @@ -16,5 +16,11 @@ declare module 'dayjs' { | |||
| startOf(unit: QUnitType): Dayjs | |||
|
|
|||
| endOf(unit: QUnitType): Dayjs | |||
|
|
|||
| isSame(date: dayjs.ConfigType, unit?: QUnitType): Dayjs | |||
There was a problem hiding this comment.
Would you import { ConfigType } at top of the code, please?
iamkun
requested changes
May 6, 2019
types/plugin/quarterOfYear.d.ts
Outdated
| @@ -16,5 +16,11 @@ declare module 'dayjs' { | |||
| startOf(unit: QUnitType): Dayjs | |||
|
|
|||
| endOf(unit: QUnitType): Dayjs | |||
|
|
|||
| isSame(date: ConfigType, unit?: QUnitType): Dayjs | |||
Fix wrong return types
iamkun
approved these changes
May 6, 2019
|
🎉 This PR is included in version 1.8.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
isSameacceptquarteras unit