Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Vim Script support #1541

Merged
merged 2 commits into from
Aug 23, 2024
Merged

feat: Add Vim Script support #1541

merged 2 commits into from
Aug 23, 2024

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Aug 23, 2024

Description:

Adds support for Vim Script.

Related Issues:

Updates #460
Fixes #1538

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis marked this pull request as ready for review August 23, 2024 03:43
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 63.20755% with 39 lines in your changes missing coverage. Please review.

Project coverage is 76.14%. Comparing base (308b0db) to head (72333dd).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/scanner/scanner.go 54.76% 24 Missing and 14 partials ⚠️
internal/scanner/state.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
- Coverage   77.11%   76.14%   -0.97%     
==========================================
  Files          17       17              
  Lines        1088     1174      +86     
==========================================
+ Hits          839      894      +55     
- Misses        182      203      +21     
- Partials       67       77      +10     
Files Coverage Δ
internal/scanner/languages.go 89.28% <100.00%> (+12.36%) ⬆️
internal/scanner/state.go 0.00% <0.00%> (ø)
internal/scanner/scanner.go 72.98% <54.76%> (-3.99%) ⬇️

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit 786713e into main Aug 23, 2024
15 checks passed
@ianlewis ianlewis deleted the vim-script branch August 23, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Skip correct number of escape characters
1 participant