chore(flink): quote every identifier for Flink SQL

ibis-project · Nov 28, 2023 · e8e344b · e8e344b
1 parent 969b9d7
commit e8e344b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 567 deletions.
diff --git a/ibis/backends/base/sql/registry/helpers.py b/ibis/backends/base/sql/registry/helpers.py
@@ -14,11 +14,9 @@ def format_call(translator, func, *args):
     return "{}({})".format(func, ", ".join(formatted_args))
 
 
-def quote_identifier(
-    name, quotechar="`", force=False, base_identifiers=identifiers.base_identifiers
-):
+def quote_identifier(name, quotechar="`", force=False):
     """Add quotes to the `name` identifier if needed."""
-    if force or name.count(" ") or name in base_identifiers:
+    if force or name.count(" ") or name in identifiers.base_identifiers:
         return f"{quotechar}{name}{quotechar}"
     else:
         return name

diff --git a/ibis/backends/flink/compiler/core.py b/ibis/backends/flink/compiler/core.py
@@ -14,13 +14,12 @@
     TableSetFormatter,
 )
 from ibis.backends.base.sql.registry import quote_identifier
-from ibis.backends.flink import identifiers
 from ibis.backends.flink.translator import FlinkExprTranslator
 
 
 class FlinkTableSetFormatter(TableSetFormatter):
     def _quote_identifier(self, name):
-        return quote_identifier(name, base_identifiers=identifiers.base_identifiers)
+        return quote_identifier(name, force=True)
 
     def _format_in_memory_table(self, op):
         names = op.schema.names