Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark target compile options/features as private #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nega0
Copy link
Contributor

@nega0 nega0 commented Jun 2, 2022

Marks target_compile_options and target_compiler features as PRIVATE. If
marked as PUBLIC, then in photosplineConfig.cmake,
set_target_properties(photospline ...) INTERFACE_COMPILE_OPTIONS and
INTERFACE_COMPLE_FEATURES are set. This tells consumers of photospline
(that use CMake) to also use these options/features.

Marks target_compile_options and target_compiler features as PRIVATE. If
marked as PUBLIC, then in photosplineConfig.cmake,
set_target_properties(photospline ...) INTERFACE_COMPILE_OPTIONS and
INTERFACE_COMPLE_FEATURES are set. This tells consumers of photospline
(that use CMake) to also use these options/features.
@nega0
Copy link
Contributor Author

nega0 commented Jun 2, 2022

aw geez, word-wrap got hosed on that commit. i can fix that prior to pulling

@cnweaver
Copy link
Collaborator

cnweaver commented Jun 2, 2022

This will work, but it will also mean that users will need to take on the responsibility of figuring out all of the CPU feature/vectorization flags they need to get good performance (bearing in mind that many of the critical hot portions of the code are in header files, so they optimized when the code using photospline is compiled, not just when photospline itself is compiled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants