Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't process captured overlay statuses #1353

Merged
merged 1 commit into from
May 30, 2022
Merged

Don't process captured overlay statuses #1353

merged 1 commit into from
May 30, 2022

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented May 30, 2022

Captured events processed by overlays are still getting processed by the widget. This skips processing the event w/ the widget if it was Captured by the overlay.

@hecrj hecrj added the bug Something isn't working label May 30, 2022
@hecrj hecrj added this to the 0.4.3 milestone May 30, 2022
hecrj
hecrj approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@hecrj hecrj merged commit 824bef6 into iced-rs:master May 30, 2022
@tarkah tarkah deleted the fix/overlay-status-capture branch May 31, 2022 00:56
hecrj added a commit that referenced this pull request May 31, 2022
@hecrj
Merge pull request #1353 from tarkah/fix/overlay-status-capture
62b37cd 
Don't process captured overlay statuses
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Sep 20, 2022
@hecrj hecrj mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working shell widget
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tarkah @hecrj