Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that window::Action::Move is unsupported on Wayland #1440

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Sep 15, 2022

https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_outer_position notes that this isn't supported on Wayland.

Wayland by design doesn't allow applications to position windows arbitrarily. GTK4 in comparison removed gtk_window_move() (which naturally didn't work on Wayland).

https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_outer_position
notes that this isn't supported on Wayland.

Wayland by design doesn't allow applications to position windows
arbitrarily. GTK4 in comparison removed `gtk_window_move()` (which
naturally didn't work on Wayland).
@13r0ck
Copy link
Member

13r0ck commented Sep 15, 2022

This is a limitation of smithay-client-toolkit not exposing a way for winit to specify a window as xdg_popup, once that is in place the new multi-window should be able to expose the type of window for wayland (either xdg_popup or xdg_toplevel)

@ids1024
Copy link
Contributor Author

ids1024 commented Sep 15, 2022

Then there will need to be a different API to provide a relative position of the popup using xdg_positioner (and similar relative positioning on X/Windows/macOS/etc.).

@ids1024
Copy link
Contributor Author

ids1024 commented Sep 15, 2022

This is a limitation of smithay-client-toolkit not exposing a way for winit to specify a window as xdg_popup

It looks like the git version of smithay-client-toolkit adds some helpers for popups, that don't exist in the release that's used in winit (though the api of smithay-client-toolkit and wayland-rs have changed a lot in breaking ways since the last release). But it should also possible to do things like that without helpers from smithay-client-toolkit, it just takes more manual code.

@13r0ck
Copy link
Member

13r0ck commented Sep 15, 2022

But it should also possible to do things like that without helpers from smithay-client-toolkit, it just takes more manual code.

PR's welcome 🤪

Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants