Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1.x deprecation warning #603

Merged
merged 9 commits into from
Sep 16, 2024
Merged

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Sep 9, 2024

Closes #545

@mfisher87 mfisher87 added the review::quick This change should not require more than 10 minutes to review label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Binder 👈 Launch a binder notebook on this branch for commit 5edc7d2

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 08db71d

Binder 👈 Launch a binder notebook on this branch for commit a33adff

Binder 👈 Launch a binder notebook on this branch for commit 4d2d232

Binder 👈 Launch a binder notebook on this branch for commit aaa90b6

Binder 👈 Launch a binder notebook on this branch for commit 0495648

Binder 👈 Launch a binder notebook on this branch for commit c6811c7

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.20%. Comparing base (bea9fe0) to head (c6811c7).
Report is 1 commits behind head on development.

❗ There is a different number of reports uploaded between BASE (bea9fe0) and HEAD (c6811c7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bea9fe0) HEAD (c6811c7)
3 2
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #603      +/-   ##
===============================================
- Coverage        71.57%   65.20%   -6.37%     
===============================================
  Files               37       37              
  Lines             3061     3064       +3     
  Branches           596      596              
===============================================
- Hits              2191     1998     -193     
- Misses             766      981     +215     
+ Partials           104       85      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfisher87 mfisher87 added the review::priority This change is preferred for review label Sep 10, 2024
icepyx/__init__.py Outdated Show resolved Hide resolved
icepyx/__init__.py Outdated Show resolved Hide resolved
icepyx/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Jessica Scheick <JessicaS11@users.noreply.github.com>
@mfisher87
Copy link
Member Author

I really wish I had more time to get the integration test workflow all smoothed out. Not sure what's going on :(

Copy link
Member

@JessicaS11 JessicaS11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewing after merges from development to see if it triggers UML+integration tests

@mfisher87 mfisher87 merged commit a98409f into development Sep 16, 2024
9 of 10 checks passed
@mfisher87 mfisher87 deleted the v1.x-deprecation-warning branch September 16, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review::priority This change is preferred for review review::quick This change should not require more than 10 minutes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation warning to icepyx v1
3 participants