Mark tests which depend on ECS as expected fail; separate integration and unit tests #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
added this to the v2: use Harmony instead of ECS as ordering and service back-end milestone
mfisher87
added
the
review::quick
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #609 +/- ##
===============================================
- Coverage 71.57% 66.88% -4.70%
===============================================
Files 37 36 -1
Lines 3061 3065 +4
Branches 596 592 -4
===============================================
- Hits 2191 2050 -141
- Misses 766 928 +162
+ Partials 104 87 -17 ☔ View full report in Codecov by Sentry. |
mfisher87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.