Change ZipFile.ReadEntries to always look for the Zip64 central directory #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know how to manually create a corrupt archive, so I will be adding a test |
|
Finally got the test working :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible change for #357 - in ZipFile.ReadEntries, always look for the zip64 central directory and use it if present, rather than only looking if we think we need it.
This change will still throw if it thinks the zip64 directory is required but can't find it (same logic there as before).
The change is sufficient to get the file from #356 loading successfully without causing any issues with the existing unit tests, but doesn't add any more tests as I don't have an appropriate test file to hand (the one linked from #356 being too large to use for a unit test)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.