Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for the Add(string fileName, string entryName) overload of ZipFile.Add #435

Merged

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Apr 5, 2020

Was looking at #112 and noticed that there is an overload of ZipFile.Add that takes an alternate file name, but that there are no unit tests for it, so thought I may as well add one.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel piksel merged commit d506c55 into icsharpcode:master Jun 19, 2020
@Numpsy Numpsy deleted the rw/zipfIe/test_add_with_alternate_name branch June 19, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants