Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in ZipAESStream.ReadBufferedData. #465

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

Helios-vmg
Copy link
Contributor

copyCount was being computed but not passed to Array.Copy(), which caused an
exception to be thrown when enough bytes were read from an encrypted stream.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

copyCount was being computed but not passed to Array.Copy(), which caused an
exception to be thrown when enough bytes were read from an encrypted stream.
@Numpsy
Copy link
Contributor

Numpsy commented May 22, 2020

My bad, I made some changes in that area to fix some issues with buffer sizes and apparently both missed that case and left a hole in the unit tests :-(

I've pushed a unit test change that reproes the issue as #466.

@piksel piksel merged commit 5addf0f into icsharpcode:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug zip Related to ZIP file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants