Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the test bootstrapper app as netcoreapp3.1 instead of netcoreapp2.0 #510

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Aug 17, 2020

I'm not sure what the intentions are for the bootstrapper app now that the github actions are running the tests directly, but:

I'm getting build warnings (visible in the appveyor build as well) about the bootstrapper app being built as .NET Core 2.0, when the test assembly that it depends on is now built as .NET Core 3.1 and .NET 4.6, so - try fixing that by retargetting it at 3.1 to match.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy
Copy link
Contributor Author

Numpsy commented Aug 18, 2020

Actually, looks like the appveyor CI is failing to run the tests altogether as is?

Invalid : C:/projects/sharpziplib/test/ICSharpCode.SharpZipLib.TestBootstrapper/bin/Debug/netcoreapp2/ICSharpCode.SharpZipLib.Tests.dll
Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
  ----> Could not load file or assembly 'System.ValueTuple, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

@piksel piksel merged commit c814877 into icsharpcode:master Feb 13, 2021
@Numpsy Numpsy deleted the rw/build/31_bootstrapper branch February 13, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants