fix(zip): 0 in zip64 local sizes using descriptors #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
=======================================
Coverage 73.83% 73.83%
=======================================
Files 69 69
Lines 8355 8355
=======================================
Hits 6169 6169
Misses 2186 2186
Continue to review full report at Codecov.
|
|
Any thoughts on when a new release will be made which includes this fix? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@carlreid no release date, but I should have the time to do so pretty soon. sorry that I cannot be more specific. |
No stress! We can wait a little more |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #736, the header tests were changed to allow for
0being passed as the Zip64 sizes when testing the archive. That is actually the correct value as per the spec, and hence this updates the output ofZipFormat.WriteLocalHeaderto write0when using descriptors together with Zip64.Fixes #744
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.