Clean up Roadmap Year/Quarter Styles #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js0mmer
reviewed
May 15, 2024
There was a problem hiding this comment.
Haven't looked at any code yet but visually it looks pretty good!
A couple things that stood out to me were:
- The context menu for quarters gets chopped off when all the quarters in that row are empty
- When a user first opens the roadmap, I don't think they'll know how to interact with the roadmap when they just see 3 rectangles with quarter names. This ties back to your point about the necessity of an onboarding tutorial but I also think that something as small as adding a message into the empty quarter saying "No courses added yet! Drag a course from the search sidebar on the right to start building your planner." could make it much easier for new users to understand what they're looking at and how to interact with it. Thoughts?
This commit should address both issues
|
js0mmer
requested changes
May 17, 2024
|
This should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Before:
After:
Steps to verify/test this change:
Final Checks: