Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Policy #223

Closed
1 task done
blalop opened this issue Oct 21, 2020 · 0 comments · Fixed by #226
Closed
1 task done

Retry Policy #223

blalop opened this issue Oct 21, 2020 · 0 comments · Fixed by #226
Assignees

Comments

@blalop
Copy link
Member

blalop commented Oct 21, 2020

Prerequisites

Description

In some cases, Teams won't be able to publish the Prometheus alerts and due to no retry policy implemented in prom2teams, those alerts will be missed.

There are two different scenarios to be considered:

  • We've sent a payload that is longer that what Teams can accept (see their docs). This should be handled inside prom2teams.
  • Teams is not available. Two responses can be expected:
    • Status code 200. Exception Microsoft.Griffin.Connectors.Store.ExchangeTooManySessionsException in body.
    • Status code 503.

Steps to Reproduce

First scenario can be easily reproduced sending a long payload. The other one depends on MS and so is not easily reproducible.

Expected behavior: Retry the alarm sending so no alarms are lost in MS Teams

Actual behavior: Some alarms are missed

Reproduces how often: Enough to be annoying

Versions

All.

Additional Information

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant