Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo #168

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Fixed typo #168

merged 2 commits into from
Apr 4, 2020

Conversation

pierrediancourt
Copy link
Contributor

@pierrediancourt pierrediancourt commented Feb 15, 2020 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Renamed "Sended" to "Sent" in the error logs.
Renamed "has" to "have" in the contribution page.

Benefits

These are now correct english wording and sentence.

Possible Drawbacks

N/A

Applicable Issues

N/A

@frantsao
Copy link
Collaborator

frantsao commented Mar 4, 2020

Thanks for your contribution. Please, add info about this change in the CHANGELOG.md file under 'Unreleased' line.

@dortegau dortegau self-requested a review April 4, 2020 12:04
@dortegau dortegau merged commit 8bb7b1f into idealista:develop Apr 4, 2020
@dortegau
Copy link
Member

dortegau commented Apr 4, 2020 •
edited
Loading

Merged into develop. Thanks for your contribution :)

@pierrediancourt pierrediancourt deleted the develop branch May 10, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frantsao frantsao frantsao approved these changes

@dortegau dortegau Awaiting requested review from dortegau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierrediancourt @frantsao @dortegau