Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61: Fix getting 404 (SERVER_NAME removed from flask app) #63

Merged
merged 2 commits into from
Apr 11, 2018

Conversation

Gkrlo
Copy link
Collaborator

@Gkrlo Gkrlo commented Apr 10, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

  • SERVER_NAME removed from flask app.
  • Casting the PORT to INT in the wsgi.py

Benefits

404 errors avoided using the docker image

Possible Drawbacks

Applicable Issues

#61
#62

@@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a changelog](https://github.com/olivierlacan/keep-a-changelog).

## [Unreleased](https://github.com/idealista/prom2teams/tree/develop)
- *[#61](https://github.com/idealista/prom2teams/pull/63) Fix getting 404 errors - SERVER_NAME removed from flask app* @Gkrlo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably #62 should be declared here :)

@Gkrlo Gkrlo merged commit 3868cca into develop Apr 11, 2018
@jnogol jnogol deleted the 61_Fix_getting_404_on_endpoints branch April 17, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants