Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Rename eval to make it SES compatible #31

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[fix] Rename eval to make it SES compatible #31

merged 2 commits into from
Apr 9, 2024

Conversation

veronicaz41
Copy link
Contributor

Rename eval to avoid SES treat this as the builtin eval function.
See this: https://github.com/endojs/endo/blob/f7dcf050ef0fd839ab6500b938791740c9bc702b/packages/ses/error-codes/SES_EVAL_REJECTED.md
The error I'm getting looks like this:

SyntaxError [Error]: Unexpected token '('
  at Object.eval (eval at makeEvaluateFactory (/Users/veronica/.config/yarn/global/node_modules/ses/dist/ses.cjs:1413:10), <anonymous>:8:30)

@veronicaz41 veronicaz41 marked this pull request as ready for review March 17, 2022 21:23
@veronicaz41 veronicaz41 changed the title fix: Rename eval to make it SES compatible [fix] Rename eval to make it SES compatible Mar 17, 2022
@veronicaz41 veronicaz41 marked this pull request as draft March 17, 2022 21:27
@veronicaz41
Copy link
Contributor Author

Actually I'm not sure about this change. Renaming this is not backward compatible. Maybe there are other projects already using eval.
Another option is to have a ses-specific build.

@veronicaz41 veronicaz41 marked this pull request as ready for review March 17, 2022 21:36
@veronicaz41
Copy link
Contributor Author

cc @phated

This was referenced Mar 29, 2022
Open
Open
Kolezhniuk
Kolezhniuk approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Kolezhniuk Kolezhniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to re-run npm run build

@OBrezhniev OBrezhniev merged commit 0d30b77 into iden3:master Apr 9, 2024
@OBrezhniev
Copy link
Member

@veronicaz41, thank you for your contribution!

@OKEAMAH OKEAMAH mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kolezhniuk Kolezhniuk Kolezhniuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veronicaz41 @OBrezhniev @Kolezhniuk