Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions improvements, replace outdated libraries #29

Merged
merged 20 commits into from
Apr 13, 2024

Conversation

indy2kro
Copy link
Contributor

@indy2kro indy2kro commented Apr 9, 2024

This pull request contains quite a lot of changes (probably would be better with several requests, but don't have the time to do it one by one):

  • Added multiple Github actions pipelines for each Laravel version supported (with supported PHP versions)
  • Bumped Node.js version in Github actions to 20 (including actions/setup-node@v4, actions/checkout@v4, actions/cache@v4)
  • Replaced set-output syntax (deprecated)
  • Updated package-lock.json with more recent versions
  • Replaced nunomaduro/larastan (deprecated) with larastan/larastan
  • Updated phpunit.xml to latest format
  • Replaced pestphp/pest-plugin-mock (deprecated) with Mockery
  • Fixed GitHelperTest.php test when running on more recent version of git

The last issue caused the test to fail when running on git 2.43 (also depends on push.autoSetupRemote configuration):

fatal: The current branch test-branch has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream test-branch test-branch

To have this happen automatically for branches without a tracking
upstream, see 'push.autoSetupRemote' in 'git help config'.

Copy link

what-the-diff bot commented Apr 9, 2024

PR Summary

  • Expanded Testing with New Job Configurations
    Additional test jobs have been set up for Laravel 9, Laravel 10, and Laravel 11 applications. As the product continues to evolve, it's vital that we verify its compatibility with newer Laravel versions for a seamless user experience. The new jobs have also been configured for proper setup and caching.

  • Updated PHP and Laravel Versions
    The PHP and Laravel versions stated in the test jobs assure that we are testing the product against the most current versions of PHP and Laravel. This enhancement will aid in the identification of potential issues early in the development cycle thereby improving product reliability.

  • Exclusion of yarn.lock File
    The yarn.lock file has now been added to .gitignore, excluding it from version control. Often, the lock files aren't necessary, especially if no actual changes to the dependencies are being made.

  • Upgraded Application Dependencies
    Dependencies and devDependencies in the composer.json and package.json files have been updated. This change assures that the latest versions of these dependencies are used, enhancing the quality of the product, by leveraging advanced features and bug fixes.

  • Enhancement of PHPUnit Tests
    The version of phpunit.xml has been upgraded. This change will allow us to leverage the latest PHPUnit features, increasing test robustness.

  • Improved Testing Mocks
    Updates have been made to various mock configurations within the test suite, providing more accurate, reliable simulations for testing. This change will improve the quality of our tests, ensuring they effectively mirror real-world scenarios.

  • Increased Integrity in Unit Testing
    The test in the tests/Unit/Traits/GitHelperTest.php file was updated, which promotes more rigorous testing of Git related features. This helps with early detection of possible issues in Git feature integrations, thus enhancing application reliability.

@igorsgm igorsgm merged commit c42045f into igorsgm:master Apr 13, 2024
7 checks passed
@igorsgm
Copy link
Owner

igorsgm commented Apr 13, 2024

LGTM! Thanks for your contribution @indy2kro.

These were great additions! Merged and released in v1.3.0

@indy2kro
Copy link
Contributor Author

The release currently contains some parameters which were meant to be implemented, but the functionality is not yet there, I will make next week another pull request with the full functionality (WIP) - If you are not ok with that functionality, the config parameters can be removed.

@igorsgm
Copy link
Owner

igorsgm commented Apr 14, 2024

Sounds good @indy2kro . I’ll be waiting for your PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants