Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ChronoUnitReader to accept - (i.e. half-days) #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdedetrich
Copy link

@mdedetrich mdedetrich commented Sep 9, 2021

This PR allows the previously added ChronoUnit reader to accept - instead as well as _, this is mainly to cover the case of half-days (currently it only accepts half_days which isn't standard for typesafe config).

This is also in sync with how decline accepts ChronoReader (see bkirwi/decline#331)

@coveralls
Copy link

coveralls commented Sep 9, 2021

Coverage Status

Coverage decreased (-2.8%) to 91.925% when pulling 98f0061 on mdedetrich:allow-chronounit-read-dash into 537fd6f on iheartradio:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants