Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1 #8657

Merged
merged 5 commits into from
May 22, 2024
Merged

Version 1.1 #8657

merged 5 commits into from
May 22, 2024

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented May 16, 2024

The second major release.

@ihhub ihhub added the improvement New feature, request or improvement label May 16, 2024
@ihhub ihhub added this to the 1.1.0 milestone May 16, 2024
@ihhub ihhub self-assigned this May 16, 2024
@ihhub ihhub marked this pull request as draft May 16, 2024 14:20
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/system/version.h Show resolved Hide resolved
src/fheroes2/system/version.h Show resolved Hide resolved
@ihhub ihhub marked this pull request as ready for review May 21, 2024 04:01
@ihhub ihhub requested review from zenseii and Districh-ru May 21, 2024 04:01
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihhub, I found one improvement. Please have a look.

changelog.txt Outdated Show resolved Hide resolved
@ihhub ihhub requested a review from zenseii May 21, 2024 09:28
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ihhub ihhub merged commit da71bd6 into master May 22, 2024
21 checks passed
@ihhub ihhub deleted the version_1.1 branch May 22, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants