Modify existing and add new delta method transformations and begin work on documentation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbi6245
commented
May 23, 2024
mbi6245
commented
- reimplemented dictionary of transformations as class
- implemented transform_percentage_change for strictly experimental data as described by Deng et al
- implemented transform_percentage_change_counts for raw count data assuming no covariance
- begin writing motivations for delta method, simple examples, and basic information about existing transformations in sphinx documentation
…lid due to use of switch statement in class constructor
…lid due to use of switch statement in class constructor
…ot have additional dependencies in test array
… 3.12 required in all relevant files, add flag to install packages without cache in build.yml
…ument transforms.py
…t for count data, add crude testing for both functions, and updated sphinx documentation with basics for all pages except api reference and developer guide
kels271828
reviewed
May 23, 2024
tests/test_transforms.py
Outdated
| def test_method_name_valid(transform): | ||
| """Raise ValueError for invalue `method`.""" | ||
| with pytest.raises(ValueError): | ||
| transform_data(VALS, VALS, transform, method='dummy') | ||
| transform_data(VALS, VALS, transform, method="dummy") |
There was a problem hiding this comment.
We recently started using pydantic for checking input. Not top priority, but if we used pydantic we could get rid of these sorts of tests!
|
Hi Max! Once we pull this branch into main, we can create smaller pull requests with branch names like feature/description, bugfix/description, docs/description, etc. That'll make each pull request more self-contained. I'll also delete my old develop branch. |
|
Thinking ahead to when we might have lots of input types (e.g., single vector of mu/sigma vs. two vectors for proportions, etc.) and methods, do you think we should have just one function users interact with or multiple? Like would the percentage functions you added be called directly or get called from |
kels271828
approved these changes
May 23, 2024
…r notebook with simulations
…simulation code for transform_percentage_change_counts
…andas dependency in pyproject.toml for testing purposes
zhengp0
reviewed
Jul 9, 2024
zhengp0
reviewed
Jul 9, 2024
zhengp0
approved these changes
Jul 9, 2024
…n functions instead of hardcoding in aforementioned class, remove bias correction in experiment percentage change, clean up simulation .ipynb file
… documentation for univariate transformations
… transformations user guide in sphinx docs
…orm_bivariate sphinx doc, and adjust testing accordingly to restructuring
…ansforms in simulations.ipynb
Restructure distrx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.