Refactor the xspline class #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengp0
added a commit
that referenced
this pull request
Aug 5, 2023
* Refactor the xspline class (#18) * add new xfunctions * add xfunction module and add cache decorator to bspl * remove the explicit cache * remove redundant integer type * add add function for xfunction and switch to tuple method for the cache * add test for poly module * add test for indi module * add test for indi module * remove old scripts * update install file * update ci to python 3.10 * update typing * add test for bspl * separate the function evaluation and argument validation * fix typo and import * format XFunction as a function wrapper * add constraint on integrals and recode add function * add test for the XFunction.add * change BundleXFunction to implement class method fun * separate out the argument checking * Add basis xfunction and convenient functions from bspl and poly * add xspline class * separate out cache clear function and auto clear in xspline * change num_basis_funs from property to len fun * add convenient import * add tests for check args and function call of xfunction * test basis xfunction * add test for xspline * add docstring for Bspl, Poly, Indi class * raise error when xfunction evaluate val and der and x.ndim == 2 * fix the type hint typo * update the installation process * Add docstring (#19) * add docstring to xfunction * remove dependency on Optional * add docstring to bspline function module * add docstring to indicator function * add docstring to poly class * add docstring for the main xspline class * remove the member function approach * Add documentation and gh-pages (#20) * change coefs to coef * add installation and example to readme file * add more examples * add final example * update badges * add code of conduct * add website documentation * remove the images in the parent folder * add gh actions to delopy docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XFunctionclass to abstract function call andappendactionBundleXFunctionclass for bundling value, derivative and integral function into aXFunctionBasisXFunctionclass for function that consists of a set of basisBspl,PolyandIndiclass as subclasses forBundleXFunction, they represet, bspline, polynomial and indicator functionXSplinefunction as subclass forBasisXFunctionthat combinesBsplandPolybased on different extrapolation options.