Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper writeup #23

Merged
merged 12 commits into from
Apr 14, 2024
Merged

JOSS paper writeup #23

merged 12 commits into from
Apr 14, 2024

Conversation

zhengp0
Copy link
Member

@zhengp0 zhengp0 commented Apr 8, 2024

Overwrite #22

@zhengp0 zhengp0 requested a review from saravkin April 8, 2024 08:19
@zhengp0 zhengp0 mentioned this pull request Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@zhengp0
Copy link
Member Author

zhengp0 commented Apr 8, 2024

Hey @saravkin! I added the paragraph in the "core idea" section, please let me know what you think. And please let me know if we need a figure there somehow to show case, in case the example I provided in the documentation isn't enough.

@saravkin
Copy link
Member

Hi @zhengp0 ! I made minor edits to the 'core idea' paragraph. I love the usage page link, and the documentation looks great, I think you can go ahead and submit to JOSS. :)

Copy link
Member

@saravkin saravkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry I did this out of order, I made a commit to the readme and then I realized I could review the request.

Not trying to add chaos here, just being myself. :)

@zhengp0
Copy link
Member Author

zhengp0 commented Apr 14, 2024

Thanks @saravkin! Will merge the branch now.

@zhengp0 zhengp0 merged commit 94e4db9 into main Apr 14, 2024
4 checks passed
@zhengp0 zhengp0 deleted the paper branch April 14, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants