-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper writeup #23
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Hey @saravkin! I added the paragraph in the "core idea" section, please let me know what you think. And please let me know if we need a figure there somehow to show case, in case the example I provided in the documentation isn't enough. |
Hi @zhengp0 ! I made minor edits to the 'core idea' paragraph. I love the usage page link, and the documentation looks great, I think you can go ahead and submit to JOSS. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Sorry I did this out of order, I made a commit to the readme and then I realized I could review the request.
Not trying to add chaos here, just being myself. :)
minor edits to core idea
Thanks @saravkin! Will merge the branch now. |
Overwrite #22