Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused Disqus variables. #1173

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Fix unused Disqus variables. #1173

merged 1 commit into from
Oct 19, 2016

Conversation

NoahDragon
Copy link
Contributor

Fix unused Disqus variables.

Fix unused Disqus variables.
@NoahDragon NoahDragon changed the title Update disqus.swig Fix unused Disqus variables. Oct 17, 2016
@iissnan
Copy link
Owner

iissnan commented Oct 17, 2016

Seems the disqus_config function does not have any usages.

@NoahDragon
Copy link
Contributor Author

NoahDragon commented Oct 17, 2016

Yeah, no one complaint about it. In my blog, I have a generated id for each post, therefore the disqus_config has to be set up properly. Otherwise, the comment count doesn't show up.

@iissnan
Copy link
Owner

iissnan commented Oct 19, 2016

It seem Disqus updated their integration. It should be OK to use both the old and the new method.

@iissnan iissnan merged commit e5926b8 into iissnan:master Oct 19, 2016
@NoahDragon NoahDragon deleted the patch-1 branch October 19, 2016 11:29
habren pushed a commit to habren/hexo-theme-next that referenced this pull request Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants