Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #1531

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Master #1531

wants to merge 4 commits into from

Conversation

cduyzh
Copy link

@cduyzh cduyzh commented Mar 23, 2017

1.添加了网易云跟帖热评文章的功能。
2.以及多说热评文章的主题配置文件参数添加。

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Apr 20, 2017

@cduyzh can u do comments in English language? I don't understand what there and can't reproducte this.

@geekrainy is that #1303 addon or what?

@geekrainy
Copy link
Contributor

@ivan-nginx He added the popular post features below the comments. This is useful for those who need it.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Apr 21, 2017

Probally code is ok, but i'm not shure.
Anyway, need to translate comments in files into English in layout/_third-party/gentie-hot-articles.swig in 1st line, for e.x.
Anyone knows Chinese? @Acris can u test it?

@@ -355,7 +359,8 @@ duoshuo_info:
admin_enable: false
user_id: 0
#admin_nickname: Author

# 多说热评文章功能
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Duoshuo hot commentary article

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DuoShuo related functionality would be deleted.

@@ -0,0 +1,15 @@
{# 网易云跟帖热评文章 #}
Copy link
Contributor

@geekrainy geekrainy Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{# Hot commentary article for NetEase gentie comments #}

<script src="https://img1.cache.netease.com/f2e/tie/yun/sdk/loader.js"></script>
<script>
var yunTieProductKey = "{{gentie_productKey}}";
var yunHotNewsWrap = "hot-news-wrap"; //放置的DOM节点ID 或 样式类
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Placed DOM id or class

Copy link
Contributor

@geekrainy geekrainy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate Chinese into English.

@@ -300,6 +300,10 @@ mathjax:
# Gentie productKey
#gentie_productKey:

# Gentie hot article
# gentie_productKey must NOT be null when gentie_hotartical is true!
#gentie_hotartical: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentie_hotartical should be gentie_hot_articles. Please don't follow the mistake.

@@ -355,7 +359,8 @@ duoshuo_info:
admin_enable: false
user_id: 0
#admin_nickname: Author

# 多说热评文章功能
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DuoShuo related functionality would be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants