Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: codeblock overflows screen when width <= 767px #1596

Merged
merged 1 commit into from
Apr 19, 2017
Merged

fix: codeblock overflows screen when width <= 767px #1596

merged 1 commit into from
Apr 19, 2017

Conversation

uchuhimo
Copy link
Contributor

Code block behaves normal on desktop, here is a demo:

codeblock-overflow-demo_desktop

But when width <= 767px (e.g. on a mobile device), it will overflow screen like this (simulate in Chrome using iPhone 6 device model):

codeblock-overflow-demo_unfixed

You can find line numbers overflow screen.

After fixed, it behaves normal again (simulate in Chrome using iPhone 6 device model):

codeblock-overflow-demo_fixed

@iissnan iissnan merged commit f6d24ae into iissnan:master Apr 19, 2017
@iissnan
Copy link
Owner

iissnan commented Apr 19, 2017

Thanks. 👍

@uchuhimo uchuhimo deleted the fix-codeblock-overflow branch April 19, 2017 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uchuhimo @iissnan