Han Support https://hanzi.pro/ #1558 #1222 #698 #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acris
reviewed
Apr 17, 2017
layout/_partials/head.swig
Outdated
| @@ -3,6 +3,11 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"/> | |||
|
|
|||
|
|
|||
| {% if theme.han %} | |||
| <link rel="stylesheet" media="all" href="//cdnjs.cloudflare.com/ajax/libs/Han/3.2.7/han.min.css"> | |||
There was a problem hiding this comment.
cloudflare的CDN在国内很慢吧？
建议不要直接引用CDN，直接将资源文件放在主题里，同时提供CDN选项，可以参考其他资源文件。
|
Thanks. 👍 |
ivan-nginx
reviewed
Apr 19, 2017
| @@ -249,7 +249,7 @@ | |||
| {% endif %} | |||
|
|
|||
|
|
|||
| <div class="post-body" itemprop="articleBody"> | |||
| <div class="post-body han-init-context" itemprop="articleBody"> | |||
There was a problem hiding this comment.
Where is the switch for han-init-context?
There was a problem hiding this comment.
It's just a hook. When Han is not enabled, it will not have any effect.
There was a problem hiding this comment.
But it's will be in default class style. It was hard to do this?
<div class="post-body{% if theme.han %} han-init-context{% endif %}" itemprop="articleBody">
There was a problem hiding this comment.
Thanks for your suggestion. ：） 756c49c
There was a problem hiding this comment.
In ideal, this switches must be anywhere on any custom options.
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.