Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add loading animation when search data is loading #1633

Merged
merged 2 commits into from
Apr 28, 2017

Conversation

uchuhimo
Copy link
Contributor

@uchuhimo uchuhimo commented Apr 28, 2017

When clicking search button first time, it will spend a long time loading search data if search.xml is large (usually 5-10 seconds), without any response. I add a loading animation to indicate the loading process. Demo:

fireshot capture 16 - uchuhimo s note - http___localhost_4000_

@ivan-nginx
Copy link
Collaborator

GJ! I'll test it soon. Wait for response.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Apr 28, 2017

@uchuhimo loading work perfectly, u can test it on my last example site.

But, it is really need to add *.svg picture, if we already have fontawesome icons? Can u check this page, there are animation icons and may be just use them instead of svg? If it's possible, of course. And if it will be better.

@uchuhimo
Copy link
Contributor Author

@ivan-nginx Thank you for reminding me, I will try and update the pull request if it's possible.

@ivan-nginx
Copy link
Collaborator

@uchuhimo firstly, need to test and try it. If FA will better, need to use it, i think.

@uchuhimo
Copy link
Contributor Author

@ivan-nginx It works. Demo:

fireshot capture 16 - uchuhimo s note - http___localhost_4000_

The appearance is similar. We can reduce the svg picture if we use animation icon.

@ivan-nginx
Copy link
Collaborator

@uchuhimo ok, do how it will be better. ;)

@uchuhimo
Copy link
Contributor Author

@ivan-nginx I have updated this pull request, check it please

@ivan-nginx
Copy link
Collaborator

@uchuhimo yeah, it's work fine and no need svg icon. Well done and thanks!

@ivan-nginx ivan-nginx merged commit 8668d1c into iissnan:master Apr 28, 2017
@uchuhimo uchuhimo deleted the feature-search-loading-animation branch April 28, 2017 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants