Upgrade jiathis share thirdpard plugin code template. #1796

elkan1788 · 2017-08-01T04:30:12Z

Upgrade jiathis share thirdpart plugin code template.

ivan-nginx

Language must not be hardcoded.

ivan-nginx · 2017-08-01T10:22:26Z

layout/_partials/share/jiathis.swig

+<a class="jiathis_button_qzone">QQ空间</a>
+<a class="jiathis_button_tqq">腾讯微薄</a>
+<a class="jiathis_button_douban">豆瓣</a>
+<a class="jiathis_button_share">一键分享</a>


Can u translate this all labels in language dir?

ivan-nginx · 2017-08-01T10:25:20Z

layout/_partials/share/jiathis.swig

+<a class="jiathis_button_douban">豆瓣</a>
+<a class="jiathis_button_share">一键分享</a>
+
+<a href="http://www.jiathis.com/share?uid=2140465" class="jiathis jiathis_txt jiathis_separator jtico jtico_jiathis" target="_blank">更多</a>


And this too.

elkan1788 · 2017-08-02T02:41:54Z

@ivan-nginx Thanks for your CR. But I don't think we need do this. This third party plugin only useful in China may not other language people. Also other share target will use in EN language. So is you still hold to your point？

elkan1788 · 2017-08-02T07:35:56Z

Upgrade the analytics script code position, because someone maybe use icons display for analytics flag. So the script not suit in head mark.

ivan-nginx

If u don't want to translate this, can u please add some comments about this is for China only?

ivan-nginx · 2017-08-02T08:47:53Z

layout/_layout.swig

@@ -44,7 +43,7 @@
    <footer id="footer" class="footer">
      <div class="footer-inner">
        {% include '_partials/footer.swig' %}
-        {% include '_third-party/analytics/busuanzi-counter.swig' %}
+	{% include '_third-party/analytics/index.swig' %}


busuanzi-counter is visible widget for footer. No need to do this.

ivan-nginx · 2017-08-02T08:48:33Z

layout/_third-party/analytics/index.swig

@@ -1,3 +1,4 @@
+{% include 'busuanzi-counter.swig' %}


busuanzi-counter is visible widget for footer. No need to do this.

Also, if u move busuanzi-counter index to widget, u must delete it from index, right?

elkan1788 · 2017-08-03T10:27:27Z

@ivan-nginx Sorry, maybe there you can't understand my explain about 56a8d62. There not only busuanzi-counter is visible widget, also other analytics script will support visible icons or lable, just like Baidu or CNZZ. You can visit my blog http://www.xn--7qv19ae78e.cn and scroll to footer, and I think you will known what I say, thanks.

ivan-nginx · 2017-08-04T07:58:06Z

@elkan1788 awesome site! China have own cyrrillic domains too, this is good.
About pull, mb i don't understand something, but as is see, u modify _third-party/analytics/index.swig file. This file include many analytics widgets, like google. And there are at most invinsible, without any widgets. Let's see:

{% include 'facebook-sdk.swig' %}
{% include 'vkontakte-api.swig' %}
{% include 'google-analytics.swig' %}
{% include 'baidu-analytics.swig' %}
{% include 'tencent-analytics.swig' %}
{% include 'tencent-mta.swig' %}
{% include 'cnzz-analytics.swig' %}
{% include 'application-insights.swig' %}

FB is integrated as API. Like and comments post is supported.
VK same as FB.
GA does not have any widgets.
Baidu have visible widget, ok.
Tencent same as GA, i think.
Tencent MTA have visible widget, i think.
CNZZ have visible widget, ok.
And AI same as GA, i think.

So, most part of this has no visible widget and if u want to see your CNZZ counter (or something else) in footer, u must do it as separated option, like busuanzi-counter.swig.

Also, u can see in history of _layout.swig file, was fix to move from body to head section for GA: 2b9e716. Pull #1705.

Please, take your time and do all rightly.

…ics with widget.

elkan1788 · 2017-08-04T10:21:27Z

@ivan-nginx Thanks for suggest and do all update under your point. Please check. :)

ivan-nginx · 2017-08-04T11:10:14Z

layout/_third-party/analytics/analytics-with-widget.swig

@@ -0,0 +1,4 @@
+{% include 'busuanzi-counter.swig' %}
+{% include 'busuanzi-counter.swig' %}


Why repeat busuanzi-counter.swig?

ivan-nginx · 2017-08-04T11:10:45Z

layout/_layout.swig

@@ -44,7 +44,7 @@
    <footer id="footer" class="footer">
      <div class="footer-inner">
        {% include '_partials/footer.swig' %}
-        {% include '_third-party/analytics/busuanzi-counter.swig' %}
+        {% include '_third-party/analytics/analytics-width-widget.swig' %}


Maybe simple analytics-widget.swig?

ivan-nginx · 2017-08-04T11:13:59Z

layout/_third-party/analytics/index.swig

@@ -1,3 +1,4 @@
+{% include 'busuanzi-counter.swig' %}
 {% include 'facebook-sdk.swig' %}
 {% include 'vkontakte-api.swig' %}
 {% include 'google-analytics.swig' %}


Also, if u move tencent, cnzz and other from index to widget, u must delete it from index, right?

ivan-nginx · 2017-08-04T11:17:20Z

layout/_third-party/analytics/analytics-with-widget.swig

@@ -0,0 +1,4 @@
+{% include 'busuanzi-counter.swig' %}
+{% include 'busuanzi-counter.swig' %}
+{% include 'tencent-mta.swig' %}


Are u tested tencent-mta.swig? I'm not sure, what is visible widget. Please, test it to be sure and also need to test tencent.swig.

ivan-nginx · 2017-08-04T11:20:56Z

@elkan1788 new comments added. Please, test it all (especially both tencent-mta) to be sure all work's ok before adding/changing pull request.

elkan1788 · 2017-08-07T02:31:22Z

@ivan-nginx So sorry about that. Now fixed the bugs and trim all analytics scripts: make sure the Tencent analytics script support widget find out in office website.

ivan-nginx · 2017-08-09T03:16:41Z

@elkan1788 seems good. Good job and thanks!

Upgrade jiathis share thirdpard plugin code template.

4c0f0aa

ivan-nginx reviewed Aug 1, 2017

View reviewed changes

Upgrade the analytics script code position

56a8d62

ivan-nginx reviewed Aug 2, 2017

View reviewed changes

add some comment about the jiathis plugin.

def0882

fix GA analytics problem refrence pull#1705 and new type about analyt…

ab2d024

…ics with widget.

Upload the new file about analytics widget

af1f704

ivan-nginx reviewed Aug 4, 2017

View reviewed changes

ivan-nginx assigned iissnan, djyde and Acris Aug 4, 2017

ivan-nginx requested review from djyde and Acris August 4, 2017 11:30

trim the analytics script and fix some bugs.

6defa2a

ivan-nginx merged commit 69159c8 into iissnan:master Aug 9, 2017

ivan-nginx added this to the v5.1.3 milestone Aug 23, 2017

ivan-nginx mentioned this pull request Oct 2, 2017

jiathis.swig有错别字 #1833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade jiathis share thirdpard plugin code template. #1796

Upgrade jiathis share thirdpard plugin code template. #1796

elkan1788 commented Aug 1, 2017

ivan-nginx left a comment

ivan-nginx Aug 1, 2017

ivan-nginx Aug 1, 2017

elkan1788 commented Aug 2, 2017 •

edited

Loading

elkan1788 commented Aug 2, 2017

ivan-nginx left a comment

ivan-nginx Aug 2, 2017

ivan-nginx Aug 2, 2017

ivan-nginx Aug 4, 2017

elkan1788 commented Aug 3, 2017

ivan-nginx commented Aug 4, 2017 •

edited

Loading

elkan1788 commented Aug 4, 2017

ivan-nginx Aug 4, 2017

ivan-nginx Aug 4, 2017

ivan-nginx Aug 4, 2017

ivan-nginx Aug 4, 2017

ivan-nginx commented Aug 4, 2017 •

edited

Loading

elkan1788 commented Aug 7, 2017

ivan-nginx commented Aug 9, 2017

		@@ -0,0 +1,4 @@
		{% include 'busuanzi-counter.swig' %}
		{% include 'busuanzi-counter.swig' %}

Upgrade jiathis share thirdpard plugin code template. #1796

Upgrade jiathis share thirdpard plugin code template. #1796

Conversation

elkan1788 commented Aug 1, 2017

ivan-nginx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elkan1788 commented Aug 2, 2017 • edited Loading

elkan1788 commented Aug 2, 2017

ivan-nginx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elkan1788 commented Aug 3, 2017

ivan-nginx commented Aug 4, 2017 • edited Loading

elkan1788 commented Aug 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivan-nginx commented Aug 4, 2017 • edited Loading

elkan1788 commented Aug 7, 2017

ivan-nginx commented Aug 9, 2017

elkan1788 commented Aug 2, 2017 •

edited

Loading

ivan-nginx commented Aug 4, 2017 •

edited

Loading

ivan-nginx commented Aug 4, 2017 •

edited

Loading