Allow the user to override the whole configuration #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 9, 2017
scripts/merge-configs.js
Outdated
| if ( data.next.override ) | ||
| hexo.theme.config = data.next | ||
| else | ||
| merge(hexo.theme.config, data.next) |
There was a problem hiding this comment.
Expected '{' and instead saw 'merge'.
Missing semicolon.
scripts/merge-configs.js
Outdated
| data && data.next && merge(hexo.theme.config, data.next); | ||
| if ( data && data.next ) { | ||
| if ( data.next.override ) | ||
| hexo.theme.config = data.next |
There was a problem hiding this comment.
Expected '{' and instead saw 'hexo'.
Missing semicolon.
Add override flag documentation
|
I just thinking about this a few days ago and you already do it. Great addition! I really appreciate this. And thank you very much to do NexT better! |
|
Thank you for bringing this so fast alive :) Best regards! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): #1860
What is the new behavior?
This PR adds a flag in the
_data/next.ymlconfiguration that allows the user to override the theme configuration. Useful if you don't want to inherit default set by the theme already.How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?