Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitment supported with mint #1919

Merged
merged 9 commits into from
Oct 6, 2017
Merged

Gitment supported with mint #1919

merged 9 commits into from
Oct 6, 2017

Conversation

aimingoo
Copy link

@aimingoo aimingoo commented Oct 3, 2017

Yes. set 'theme.gitment.mint: true' to active Gitmint.

  • support gitment and gitmint, choice by 'mint' option in _config.yml
  • support multi-language, force setting or automatic detect, 'mint' required
  • support lazy, tks LEAFERx
  • support hide 'Powered by ...' on footer, and more
  • support comments count show and update, 'mint' required
  • support no client_secret if you have a proxy, 'mint' required
  • support override force_redirect_protocol, 'mint' required

and, the aimingoo/Gitmint project updated to support these features.

@aimingoo aimingoo mentioned this pull request Oct 3, 2017
Closed
@ivan-nginx ivan-nginx added this to the v5.1.4 milestone Oct 3, 2017
@ivan-nginx ivan-nginx removed their request for review October 3, 2017 16:56
@ivan-nginx ivan-nginx merged commit eabf6f6 into iissnan:master Oct 6, 2017
@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Oct 6, 2017 •
edited
Loading

Thank's for this PR and for Gitmint! To @aimingoo and to @LEAFERx too! Really good job, guys.

@ivan-nginx ivan-nginx mentioned this pull request Jan 19, 2018
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djyde djyde Awaiting requested review from djyde

@Acris Acris Awaiting requested review from Acris

@iissnan iissnan Awaiting requested review from iissnan

Assignees
No one assigned
Labels
3rd party service 4 - Done Docs Enhancement
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@aimingoo @ivan-nginx @LEAFERx