-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1943 fix the bug of gitment #1944
Conversation
fix the bug of gitment, change `document.location.href` to `document.location.pathname`
In #1943 instead of |
@ivan-nginx Sorry, I haven't tested it yet, just modify the file as what @icearith say. But I see somebody have tested it in imsun/gitment#46. |
This modification could only be a hot-fix level solution for this issue, because this is a problem related to the design of Gitment. Some guys mentioned that Gitment should use Although this solution is not 100% reliable, it could also improve the reliability of this plugin, because many links pass arguments to URLs, for example, http://a.com?from=baidu this is regarded as a different post from http://a.com. This commit could solve this issue from URL level, the issues mentioned in imsun/gitment#46 should be label as a upstream issue, which should be solved in upstream repository. |
So? What's the difference between |
Sorry, I think It's ok to close this PR, and wait somebody or me have better solution, then fix this bug. |
@ivan-nginx I mean, the point is that |
It's ok to do 100% bugfix PR's. And it's ok to test all changes before make PR into master branch. Guys, let me explain there something. There is 3 ways:
What's the right answer? 😃 P.S. I don't talk about «Oh no, u not tested it, this is wrong bugfix, etc.». A just talking about right way to fix. |
fix the bug of gitment, change
document.location.href
todocument.location.pathname
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): N/A
What is the new behavior?
Description about this pull, in several words...
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?