Make module-alias work in cli mode #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require.main is undefined when running from cli - don't use unless it exists
- This require introducing a way of having "require.main" undefined in our module. The require function is different between the test module and the module under test, so we can't just do `require.main = null` in the test function, as it won't affect the "require" function of the prod code. So we need to introduce a helper function for evaluating require.main, and injact a flag in the test module when running the tests.
ilearnio
approved these changes
Oct 1, 2019
|
Awesome stuff! Thanks @Kehrlann! |
|
Published as v2.2.2 |
This was referenced Mar 28, 2020
This was referenced Sep 13, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
It builds on top of @dgobaud's PR, and adds tests.
There might be some rare cases when you want to use module-alias while running in a REPL (e.g.
$ node -i). In that case,require.mainis undefined.This means introducing a way of having "require.main" undefined in our module. The require function is different between the test module and the module under test, so we can't just do
require.main = nullin the test function, as it won't affect the "require" function of the prod code. So we need to introduce a helper function for evaluating require.main, and inject a flag in the test module when running the tests.