(c2rust-analyze/tests) Add tests for string literals and casts
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filecheck.rs` and in preparation for other analyze-only tests.
…y're `cfg`ed off as they're not yet supported.
kkysen
changed the title
c2rust-analyze/test) Add tests for string literals and castsc2rust-analyze/tests) Add tests for string literals and casts
aneksteind
reviewed
Feb 16, 2023
…ctly, rather than going through `cargo` again. Skipping going through `cargo` makes the tests run much faster, but more importantly, prevents them from competing for the `target/` lock, which caused issues in CI on macOS sometimes. It's also a bit simpler now, not needing to go through `cargo`.
aneksteind
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for string literals and casts.
They are currently unsupported:
c2rust-analyze) Handle transpiled string literals (b"...\0" as *const u8 as *const libc::c_char) #833c2rust-analyze) Handle string literals #837so for now the tests are skipped over with
#[cfg(any())]. Once those issues are fixed, these tests will be turned back on, but it's easier to start with the tests existing.These tests just check if
c2rust-analyzedoesn't crash on them, similar to the existinglighttpd-minimaltest. For theFileChecktests,FileCheckrequires at least oneCHECK:command, which we don't want. Thus, I've renamedlighttpd.rstoanalyze.rsand it'll be forc2rust-analyze-only tests, as opposed tofilecheck.rsforc2rust-analyze+FileChecktests.Furthermore, running
cargoconcurrently (due to multiple tests) forc2rust-analyzecrashes in macOS CI, so now thec2rust-analyzebinary is found to run directly, rather than going throughcargoagain.Skipping going through
cargomakes the tests run much faster, but more importantly, prevents them from competing for thetarget/lock, which caused issues in CI on macOS sometimes. It's also a bit simpler now, not needing to go throughcargo.