-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analyze: refactor MIR rewrite generation #919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneksteind
reviewed
May 10, 2023
aneksteind
reviewed
May 10, 2023
aneksteind
reviewed
May 10, 2023
aneksteind
reviewed
May 10, 2023
aneksteind
reviewed
May 10, 2023
spernsteiner
force-pushed
the
analyze-misc-fixes-20230509
branch
from
May 10, 2023 16:08
e02e0b8
to
e313cbd
Compare
aneksteind
reviewed
May 10, 2023
spernsteiner
changed the base branch from
analyze-misc-fixes-20230509
to
analyze-refactor-mir-casts-base
May 10, 2023 16:22
aneksteind
reviewed
May 10, 2023
aneksteind
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nice-to-have but nothing blocking
This was referenced May 10, 2023
spernsteiner
force-pushed
the
analyze-refactor-mir-casts
branch
from
May 10, 2023 18:02
a3c7290
to
d1975e4
Compare
spernsteiner
changed the base branch from
analyze-refactor-mir-casts-base
to
master
May 10, 2023 18:03
I rebased this onto |
Fixed the test failure by skipping rewrite generation for |
spernsteiner
force-pushed
the
analyze-refactor-mir-casts
branch
from
May 10, 2023 20:49
12febdf
to
a012718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch refactors
mir_op
to make the generation of conversions more uniform. Ideally, we should callemit_cast_*
in roughly every place wheredataflow::type_check
adds a dataflow edge. This branch doesn't fully implement that, but gets us a little closer.This also adds a new
TypeDesc
type, which bundles upOwnership
,Quantity
, and a pointeeTy
into a complete description of a rewritten pointer type. This is used for some of the newemit_cast_*
machinery.Based on #918 for now; once this is approved, I'll rebase onto
master