Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] get community #1050

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[bugfix] get community #1050

merged 1 commit into from
Nov 21, 2023

Conversation

dev-jotape
Copy link
Collaborator

This PR fixes #1045

Changes

We are receiving some requests with the community id/address undefined

20-11-2023 13:09:43.000[heroku-logs][INFO][postgres.3691435][heroku][PURPLE] [11-1] sql_error_code = 42703 time_ms = "2023-11-20 16:09:43.169 UTC" pid="1476985" proc_start_time="2023-11-20 16:09:31 UTC" session_id="655b84bb.168979" vtid="7/990919" tid="0" log_line="3" database="d56l4mho1dkh25" connection_source="34.246.134.116(59594)" user="u57h2uepi221ft" application_name="[unknown]" ERROR: column "nan" does not exist at character 1299
20-11-2023 13:09:43.172[heroku-logs][INFO][router][heroku]at=info method=GET path="/api/v2/communities/undefined?state=base" host=impactmarket-api-production.herokuapp.com request_id=3adf607e-c7c7-4969-bfe2-71aa73455374 fwd="3.238.197.136" dyno=web.1 connect=0ms service=7ms status=400 bytes=5899 protocol=https

To fix that, the input will be validated before doing the SQL query.

Tests

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dev-jotape dev-jotape changed the title [fix] get community [bugfix] get community Nov 20, 2023
@obernardovieira obernardovieira merged commit 459aeaa into main Nov 21, 2023
8 checks passed
@obernardovieira obernardovieira deleted the fix/get-community branch November 21, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obernardovieira obernardovieira obernardovieira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sql error trigger] column "nan" does not exist
2 participants
@dev-jotape @obernardovieira