Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ExportMap: Add default export when esModuleInterop is true and anything is exported #2184

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

Maxim-Mazurok
Copy link
Contributor

This PR aims to fix #2183 by adding default export if anything is exported and esModuleInterop is set to true.

This probably should've been done in #1689 that I originally opened to add esModuleInterop support.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems good.

src/ExportMap.js Outdated Show resolved Hide resolved
src/ExportMap.js Outdated Show resolved Hide resolved
@ljharb ljharb changed the title Add default export when esModuleInterop is true and anything is exported [Fix] ExportMap: Add default export when esModuleInterop is true and anything is exported Aug 10, 2021
@ljharb ljharb merged commit ce540b6 into import-js:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[import/default] - false negative for react-test-renderer
2 participants