Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add modern build with bot detection #56

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

felixranesberger
Copy link
Contributor

This pull request introduces an internal modern ESM build that will have an integrated bot detection built in.
This is a test to improve pagespeed in combination with Lux.

@einpraegsam
Copy link
Contributor

If I try the feature branch I ran into problems when doing a npm run build - maybe the nvm version is different?

Failure:

npm run build

> lux@ build /var/www/PhpstormProjects/lux/Resources/Private/Build
> ./node_modules/gulp/bin/gulp.js build && unbuild

[12:44:55] Using gulpfile /var/www/PhpstormProjects/lux/Resources/Private/Build/gulpfile.js
[12:44:55] Starting 'build'...
[12:44:55] Starting 'jsFrontend'...
[12:44:57] Finished 'jsFrontend' after 1.77 s
[12:44:57] Starting 'jsBackend'...
[12:44:57] Finished 'jsBackend' after 211 ms
[12:44:57] Starting 'css'...
[12:44:57] Finished 'css' after 172 ms
[12:44:57] Finished 'build' after 2.16 s
sh: 1: unbuild: not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! lux@ build: `./node_modules/gulp/bin/gulp.js build && unbuild`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the lux@ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/einpraegsam/.npm/_logs/2024-09-16T10_44_58_015Z-debug.log

@einpraegsam einpraegsam merged commit 7b0137a into develop Sep 16, 2024
14 checks passed
@einpraegsam einpraegsam deleted the feature/bot-detection branch September 16, 2024 11:11
@felixranesberger felixranesberger changed the title [FEATURE][DRAFT] Add modern build with bot detection [FEATURE] Add modern build with bot detection Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants