Re-deprecate remove, remove_entry, and take
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a frequent point of confusion that these methods disrupt the order (by swapping the last item), but that choice was made for performance. The alternative `shift_*` removals are also disruptive to indices, and require O(n) updates instead of O(1). The deprecation notes recommend instead choosing a swap/shift method explicitly. This doesn't mean that we'll ever actually _remove_ these deprecated methods, since they are still nice to have when acting as a drop-in `HashMap` replacement, but the warning will hopefully help avoid surprises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a frequent point of confusion that these methods disrupt the order
(by swapping the last item), but that choice was made for performance.
The alternative
shift_*removals are also disruptive to indices, andrequire O(n) updates instead of O(1).
The deprecation notes recommend instead choosing a swap/shift method
explicitly. This doesn't mean that we'll ever actually remove these
deprecated methods, since they are still nice to have when acting as a
drop-in
HashMapreplacement, but the warning will hopefully help avoidsurprises.
Resolves #241.
Resolves #220.