Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for window can become key #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for window can become key #12

wants to merge 3 commits into from

Conversation

thibaut-jarosz
Copy link
Contributor

This allows popvover to be shown without main window resigning key.

@Arcnor
Copy link

Arcnor commented Jan 24, 2014

Is there a reason this hasn't been merged yet?

@dbrisinda
Copy link

dbrisinda commented Jan 18, 2017

It seems to me that this line is somewhat problematic as it requires additional setup:

if ( _windowCanBecomeKey )
    [positionWindow makeKeyAndOrderFront:nil];

I found another way for document-based apps that use many windows. For example, clicking another document window, which will close the popover, and allow the newly clicked document window to remain key:

if (positionWindow.mainWindow)
    [positionWindow makeKeyAndOrderFront:nil];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants