fix for issue 28 #33
Open
fix for issue 28 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add arc compatibility, solving issue with KeyView loop, add podspec
Sample code wasn't using ARC for INPopoverController, my previous ARC conversion wasn't working.
Fixing crash with ARC
Fixing Arc crash
Border was drawn on half pixels on odd border width
Fixed border drawing glitch
Compilation error with ARC
Thanks to @truppelito for the solution.
Fixed source files location in podspec.
Added option to close popover when escape key is pressed.
copy/paste fail
NSRectEdge -> NSUInteger to support OSX 10.11
indragiek
force-pushed
the
master
branch
2 times, most recently
from
82c4c58
to
ba272ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _popoverWindow gets into a state where isVisible is YES, but alphaValue is 0
Because popoverIsVisible is true in togglePopover, it will always attempt to close it, never opening it and setting alpha back to 1.0
This seems to be happening because of a race condition where the animation delegate is set to nil before the animation started in INPopoverWindow.dismissAnimated is finished. So INPopoverController animationDidStop is never called.
It isn't really a thread synchronization issue because all this happens on the main thread.