-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration option for ipv4 or ipv6, defaults to ipv4 #92
feat: add configuration option for ipv4 or ipv6, defaults to ipv4 #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:
- Update
CHANGELOG.md
- Update
README.md
with information how to configure ipv6:
- Please add a documentation for new configuration option (
ipVersion
) in a Client constructor:
public function __construct(array $options)
and also:
9909e2c
to
359085e
Compare
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
============================================
- Coverage 82.24% 81.60% -0.65%
- Complexity 375 378 +3
============================================
Files 23 23
Lines 890 897 +7
============================================
Hits 732 732
- Misses 158 165 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
Closes #91
Proposed Changes
New configuration option for IPv4 or IPv6
Checklist
make test
completes successfully