Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration option for ipv4 or ipv6, defaults to ipv4 #92

Merged

Conversation

kevin0x90
Copy link
Contributor

@kevin0x90 kevin0x90 commented Sep 14, 2021

Closes #91

Proposed Changes

New configuration option for IPv4 or IPv6

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@kevin0x90 kevin0x90 changed the title Add configuration option for ipv4 or ipv6, defaults to ipv4 feat: add configuration option for ipv4 or ipv6, defaults to ipv4 Sep 14, 2021
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:

  1. Update CHANGELOG.md
  2. Update README.md with information how to configure ipv6:
    image
  3. Please add a documentation for new configuration option (ipVersion) in a Client constructor:
    public function __construct(array $options)

and also:

src/InfluxDB2/UdpWriter.php Outdated Show resolved Hide resolved
@kevin0x90 kevin0x90 force-pushed the feature/#91-udpwriter-add-ipv6-support branch from 9909e2c to 359085e Compare September 15, 2021 19:25
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #92 (e319395) into master (7a3d92c) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     82.24%   81.60%   -0.65%     
- Complexity      375      378       +3     
============================================
  Files            23       23              
  Lines           890      897       +7     
============================================
  Hits            732      732              
- Misses          158      165       +7     
Impacted Files Coverage Δ
src/InfluxDB2/Client.php 93.54% <ø> (ø)
src/InfluxDB2/UdpWriter.php 38.23% <0.00%> (-9.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3d92c...e319395. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍

@bednar bednar merged commit 2e69dbf into influxdata:master Sep 16, 2021
@bednar bednar added this to the 2.2.0 milestone Sep 16, 2021
@kevin0x90 kevin0x90 deleted the feature/#91-udpwriter-add-ipv6-support branch September 16, 2021 09:49
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UdpWriter does not support IPv6
3 participants