Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tendermint-proto: grpc feature lost in Tendermint v0.35 shuffle #1225

Open
tony-iqlusion opened this issue Nov 10, 2022 · 3 comments
Open

tendermint-proto: grpc feature lost in Tendermint v0.35 shuffle #1225

tony-iqlusion opened this issue Nov 10, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tony-iqlusion
Copy link
Collaborator

tony-iqlusion commented Nov 10, 2022

@tomtau added a grpc feature to the tendermint-proto crate in #1137

However it seem it was lost in the shuffle around Tendermint v0.35.

It's needed to implement gRPC "privval" support, as in #1152.

See also: #1134

@tony-iqlusion
Copy link
Collaborator Author

tony-iqlusion commented Nov 10, 2022

I opened #1227 which cherry-picks the changes from #1137 onto main with some slight modifications

@tony-iqlusion
Copy link
Collaborator Author

Note: the privval side of things is blocked on tendermint/tendermint#9256

@erwanor
Copy link
Collaborator

erwanor commented Jul 24, 2023

@tony-iqlusion I opened #1338 which includes the server definitions for the rpc and abci service, but not for privval because it's blocked on #9256. I just realized that I used tonic-build@0.9 instead of tonic-build@0.8 in that PR, I can change that.

My motivation is that we want to add gRPC in tower-abci and unfortunately the privval service is blocked by cometbft upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants