tendermint-proto: Add a feature flag and generate gRPC server definitions #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions - `proto-compiler` uses `tonic-build` - tendermint-proto can be compiled with std for the `grpc` feature (as required by the generated `tonic` code) - the primary motivation is the new gRPC-based PrivVal interface in Tendermint 0.35 (see informalsystems#1134)
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
======================================
Coverage 64.7% 64.7%
======================================
Files 231 231
Lines 15637 15637
======================================
+ Hits 10121 10122 +1
+ Misses 5516 5515 -1
Continue to review full report at Codecov.
|
This was referenced May 30, 2022
|
@thanethomson +1 on this. It would unblock gRPC work on TMKMS |
tomtau
added a commit
to tomtau/tendermint-rs
that referenced
this pull request
Jun 10, 2022
a proposed follow-up after informalsystems#1137 is merged. ref: informalsystems#1134
thanethomson
approved these changes
Jun 11, 2022
There was a problem hiding this comment.
Sorry for the delayed review, I've been on vacation and traveling and have only had a chance to review this now. This is excellent, thanks @tomtau! 🎉
|
thanks @thanethomson , this unblocks some of the Tendermint 0.35 support work. |
tony-iqlusion
pushed a commit
that referenced
this pull request
Nov 10, 2022
Adds a "grpc" feature to the crate along with gRPC server definitions for the "privval" interface used by e.g. TMKMS to support remote signing. These were originally added in #1137 but lost in the shuffle of Tendermint v0.35-related changes. They have been updated to use `tonic` v0.8, which the `tendermint-proto` crate updated to after the original #1137 PR landed.
5 tasks
tony-iqlusion
pushed a commit
that referenced
this pull request
Nov 10, 2022
Adds a "grpc" feature to the crate along with gRPC server definitions for the "privval" interface used by e.g. TMKMS to support remote signing. These were originally added in #1137 but lost in the shuffle of Tendermint v0.35-related changes. They have been updated to use `tonic` v0.8, which the `tendermint-proto` crate updated to after the original #1137 PR landed.
tony-iqlusion
pushed a commit
that referenced
this pull request
Nov 10, 2022
Adds a "grpc" feature to the crate along with gRPC server definitions for the "privval" interface used by e.g. TMKMS to support remote signing. These were originally added in #1137 but lost in the shuffle of Tendermint v0.35-related changes. They have been updated to use `tonic` v0.8, which the `tendermint-proto` crate updated to after the original #1137 PR landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto-compilerusestonic-buildgrpcfeature(as required by the generated
toniccode)in Tendermint 0.35
(see generate privval gRPC server and provide a high-level pluggable default implementation #1134)
.changelog/