Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: Introduce HTTP timeouts #1379

Closed
mdyring opened this issue Nov 14, 2023 · 0 comments · Fixed by #1380
Closed

rpc: Introduce HTTP timeouts #1379

mdyring opened this issue Nov 14, 2023 · 0 comments · Fixed by #1380
Labels
enhancement New feature or request

Comments

@mdyring
Copy link
Contributor

mdyring commented Nov 14, 2023

Description

Add configurable timeout that is passed to reqwest. The current default is "no timeout", which can lead to requests never finishing.

Definition of "done"

Add timeout() to request builder and wire it into reqwest.
@mdyring mdyring added the enhancement New feature or request label Nov 14, 2023
mdyring added a commit to mdyring/tendermint-rs that referenced this issue Nov 14, 2023
@mdyring
rpc: Add HTTP timeout, default 30 seconds.
e2d3913 
Closes informalsystems#1379.
@mdyring mdyring mentioned this issue Nov 14, 2023
Merged
5 tasks
@rllola rllola mentioned this issue Mar 4, 2024
Closed
romac pushed a commit that referenced this issue Mar 13, 2024
@mdyring
rpc: Add HTTP timeout, defaulting to 30 seconds (#1380)
7fc6d9a 
* rpc: Add HTTP timeout, default 30 seconds.

Closes #1379.

* Add .changelog entry
romac added a commit that referenced this issue Mar 13, 2024
@romac
Update changelog entry for #1379
3d31a60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: Add HTTP timeout, default 30 seconds. mdyring/tendermint-rs
1 participant
@mdyring